-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to uv
python tool
#579
Open
jeremyestein
wants to merge
12
commits into
jeremy/refactor-dockerfiles
Choose a base branch
from
jeremy/uv-python
base: jeremy/refactor-dockerfiles
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jeremy/refactor-dockerfiles #579 +/- ##
===============================================================
+ Coverage 85.17% 87.38% +2.21%
===============================================================
Files 72 76 +4
Lines 3116 3386 +270
===============================================================
+ Hits 2654 2959 +305
+ Misses 462 427 -35 ☔ View full report in Codecov by Sentry. |
installed is a pre-requisite for running the system test script.
jeremyestein
force-pushed
the
jeremy/uv-python
branch
from
December 21, 2024 12:17
78af209
to
182490a
Compare
jeremyestein
changed the base branch from
main
to
jeremy/refactor-dockerfiles
December 21, 2024 12:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #{issue_number}: A few words or sentences describing the changes proposed in this pull request (PR).
Known TODOs:
pip
uv sync --all-extras --all-packages
is currently needed to get pytest. I'd expect just extras to be needed. Do I need to add extras section to root pyproject and link to workspace extras?pyproject.toml
files are reflected in theuv.lock
file so it can be committed too?setuptools
in pixl_dcmd just for the sake of pydicom? Shouldn't it be responsible for its own dependencies?Type of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.squash and merge